Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure composer is allowed to run as root in the builder step #276

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Apr 16, 2024

Since composer 2.7.0, plugins are no longer loaded if composer is executed as root.
This has caused some trouble, both in this repo and in others

This PR addressed this by allowing composer to be executed as superuser.
This is not a setting you want to set in production, but in this case of a CI pipeline where that RUN step is executed in a separate stage, this is ok.

I also added a minimal CI file that tests is a PR is buildable based on the latest Mautic 5 dev version

Copy link

@nick-vanpraet nick-vanpraet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, solves the issue

@mollux mollux merged commit 084bcee into mautic:mautic5 Apr 16, 2024
2 checks passed
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants